commit c225d88d49f5cfd3c6e562700131cc7006d6d57a
parent ed78aef5b180cf1d82f03e8ae43c62317f273962
Author: Michael Forney <mforney@mforney.org>
Date: Sun, 3 Sep 2017 15:39:47 -0700
getconf: Report invalid variables as errors
Printing `undefined` to stdout means that the variable is valid but not
set. Instead, report an error in this case.
linux 4.13 appends the result of `getconf LFS_CFLAGS` to HOSTCFLAGS,
even if it prints `undefined`. This is arguably a bug in the Makefile,
but even so, getconf shouldn't report that unsupported variables are
valid.
Diffstat:
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/getconf.1 b/getconf.1
@@ -32,7 +32,7 @@ and limits.h (Minimum and Maximum).
.sp
If
.Ar var
-is not defined or has not been found,
+is not defined,
.Nm
writes "undefined" to stdout.
.Sh OPTIONS
@@ -48,7 +48,7 @@ was matched and its value written successfully.
.It 1
An error occured or
.Ar var
-was neither defined nor found.
+was invalid.
.El
.Sh STANDARDS
The
diff --git a/getconf.c b/getconf.c
@@ -102,7 +102,5 @@ main(int argc, char *argv[])
usage();
}
- puts("undefined");
-
- return 1;
+ eprintf("invalid variable: %s\n", argv[0]);
}