noice

small file browser
git clone git://git.2f30.org/noice
Log | Files | Refs | README | LICENSE

commit 4b56e4a122c9c16d00f459a992496423e2abce63
parent b6c43f66a9adeb7e3f19d6cffc9c14abf60dd855
Author: lostd <lostd@2f30.org>
Date:   Wed,  8 Oct 2014 15:14:11 +0300

Avoid sprintf(3) and use snprintf(3) instead

Diffstat:
Mnoice.c | 7++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/noice.c b/noice.c @@ -347,6 +347,7 @@ nochange: } if (ret == 3) { char *pathnew, *pathtmp; + size_t pathsiz; char *name; u_int8_t type; char *bin; @@ -360,9 +361,9 @@ nochange: name = dents[cur]->d_name; type = dents[cur]->d_type; - pathnew = malloc(strlen(path) + 1 - + strlen(name) + 1); - sprintf(pathnew, "%s/%s", path, name); + pathsiz = strlen(path) + 1 + strlen(name) + 1; + pathnew = malloc(pathsiz); + snprintf(pathnew, pathsiz, "%s/%s", path, name); DPRINTF_S(name); DPRINTF_U(type);